feat: remove Roomote Control from extension#11271
Conversation
Remove all Roomote Control (remote control) functionality: - Remove BridgeOrchestrator and entire bridge directory from @roo-code/cloud - Remove remoteControlEnabled, featureRoomoteControlEnabled from extension state - Remove extensionBridgeEnabled from CloudUserInfo and user settings - Remove roomoteControlEnabled from organization/user feature schemas - Remove enableBridge from Task and ClineProvider - Remove remote control toggle from CloudView UI - Remove remoteControlEnabled message handler - Remove extension bridge disconnect on logout/deactivate - Update CloudTaskButton to show for all logged-in users - Remove remote control translation strings from all locales - Update all related tests CLO-765
Clean removal overall. Two minor cleanup items left behind by the deletion of the bridge subsystem:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| private async isExtensionBridgeEnabledForOrganization(organizationId: string): Promise<boolean> { | ||
| const orgMetadata = await this.getOrganizationMetadata(organizationId) | ||
| return orgMetadata?.public_metadata?.extension_bridge_enabled === true | ||
| } |
There was a problem hiding this comment.
Removing isExtensionBridgeEnabledForOrganization leaves the private getOrganizationMetadata method (lines 721-744) with zero callers -- it's now dead code. Worth removing it in this PR to keep the cleanup complete.
Fix it with Roo Code or mention @roomote and request a fix.
|
|
||
| export { BridgeOrchestrator } from "./bridge/index.js" |
There was a problem hiding this comment.
With the bridge directory deleted, socket.io-client in packages/cloud/package.json has no remaining consumers. Consider removing it to avoid shipping an unused dependency.
Fix it with Roo Code or mention @roomote and request a fix.
1 participant
Remove all Roomote Control (remote control) functionality from the extension.
Changes
Types (
packages/types/)extensionBridgeEnabledfromCloudUserInfointerfaceroomoteControlEnabledfromorganizationFeaturesSchemaanduserFeaturesSchemaextensionBridgeEnabledfromuserSettingsConfigSchemaremoteControlEnabledandfeatureRoomoteControlEnabledfromExtensionState"remoteControlEnabled"from webview message typesCloud Package (
packages/cloud/)bridge/directory (BridgeOrchestrator, ExtensionChannel, TaskChannel, SocketTransport, BaseChannel)StaticSettingsService(remove roomoteControlEnabled and extensionBridgeEnabled)StaticTokenAuthService(remove extensionBridgeEnabled from user info)WebAuthService(remove extensionBridgeEnabled logic and isExtensionBridgeEnabledForOrganization)Extension (
src/)extension.tsdeactivateremoteControlEnabled()calls from auth/settings handlersClineProvider.remoteControlEnabled()method entirelyremoteControlEnabledandfeatureRoomoteControlEnabledfromgetState()enableBridgefrom Task class and all bridge subscription logic"remoteControlEnabled"message handler from webviewMessageHandlerWebView UI (
webview-ui/)remoteControlEnabled,featureRoomoteControlEnabledfrom ExtensionStateContextTests
56 files changed, 25 insertions, 2,761 deletions
View task on Roo Code Cloud
Important
Remove all Roomote Control functionality from the extension, including types, cloud package components, extension logic, UI elements, and tests.
extensionBridgeEnabledfromCloudUserInfo.roomoteControlEnabledfromorganizationFeaturesSchemaanduserFeaturesSchema.extensionBridgeEnabledfromuserSettingsConfigSchema.remoteControlEnabledandfeatureRoomoteControlEnabledfromExtensionState."remoteControlEnabled"from webview message types.bridge/directory (includingBridgeOrchestrator,ExtensionChannel,TaskChannel,SocketTransport,BaseChannel).BridgeOrchestratorexport fromindex.StaticSettingsService,StaticTokenAuthService, andWebAuthServiceto remove related logic.BridgeOrchestratorimport and bridge disconnect fromextension.tsdeactivate.remoteControlEnabled()calls from auth/settings handlers.ClineProvider.remoteControlEnabled()method entirely.remoteControlEnabledandfeatureRoomoteControlEnabledfromgetState().enableBridgefromTaskclass and all bridge subscription logic."remoteControlEnabled"message handler fromwebviewMessageHandler.CloudView.remoteControlEnabled,featureRoomoteControlEnabledfromExtensionStateContext.CloudTaskButtonto show for all logged-in users.packages/types,packages/cloud,src, andwebview-ui.BridgeOrchestratormocks from test files.This description was created by
for dc40ba1. You can customize this summary. It will automatically update as commits are pushed.